Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pagination - countries stats #407

Open
mbiesiad opened this issue Sep 9, 2024 · 5 comments
Open

Missing pagination - countries stats #407

mbiesiad opened this issue Sep 9, 2024 · 5 comments

Comments

@mbiesiad
Copy link

mbiesiad commented Sep 9, 2024

Hi,
In recent weeks there was some change which led to missing pagination (at least) - countries stats.

Repro steps:

Go to country stats, for example visit: https://ctftime.org/stats/PL or https://ctftime.org/stats/DE
Scroll down - notice missing previously visible pagination.

Issue:

At this moment you can not see how many teams are in selected country (ie.: 2024 year).

Moreover, if we visit https://ctftime.org/stats/PL we can see 'Top 19' (Country position col.). While visiting https://ctftime.org/stats/DE we can see 'Top 25'.

For new users or visitors it can leads to misinformation, because visitors can think that selected country has only this teams number.
Quick example: let's take a look at https://ctftime.org/stats/PL with "19 teams" at this moment. If we check how it looked like before, we can see 3 sites of pagination for this case - please notice that there was also 'Top 50 country teams' displayed (not '19' - for first pagination site). That means for this case there is no '19' teams, but over than '100'. Similar issue occurs with other countries now (as mentioned).

Additional informations:

'In recent weeks' - it looks like dates: 2024-07-08 or even 2024-08-05 that was fine, pagination was OK (at least for PL country stats) for example.

Current view:
ctf1a

Previous view (pagination):
ctf1ab

Best regards,

@AlfredSimpson
Copy link

Adding on to this - the count seems to be limited to the top 999 teams in the world. This explains why some countries have many showing and some have none.

image
You'll see that in this screenshot I am on Page 20 - and can progress no further. We're looking at global teams in this view. It caps at 999. However, as @mbiesiad mentioned, there are significantly more teams in the world.

image

Not sure if the way team rankings show will fundamentally change or if something on the back-end has nuked it.

I do know that teams who are not in the top 999 in the world will be listed as tied for the next rank in their nation.

For example, in the United States we list 85 teams. Any team not in the top 999 in the world will show as tied for 86th, like so:
image

@CyberSSM
Copy link

This is also a problem for Teams out side the top 10 in individual countries.

BUT that's not all The Individual Team Page has no points total or position (in country or overall). For those who have developing Teams its nice to be able to track how the team is developing - especially as we are coming up to close of year. It would be great to get this fixed as a priority. Given its been like this for 8 weeks now. THANK YOU in anticipation.

@mbiesiad
Copy link
Author

mbiesiad commented Dec 8, 2024

Similar issues noticed by CTF community #426 and #430

from possible Sponsors point of view it's also important, there is a difference between be a:
3rd Team in country from total 300+
3rd Team in country from 15 or 20 (displayed)
and so on.

please notice also that sponsors, as well as new members / visitors can read it this way (understated / underrated achievements) - and that's just what they see now

(for me, it's a bug/issue worth to fix / revert previous version), Best

@mbiesiad
Copy link
Author

mbiesiad commented Dec 8, 2024

Since changes described in this issue, appeared also the issue described with #426 and #430

PS. Currently this creates chaos with the data - if a new visitor checks one displayed data and compares it with another (even on the same site), quick example - currently:
https://ctftime.org/stats/DE shows at the bottom "DE — 1162"
while the table shows:
"28" as max in "Country position" column.
How are people who have not used CTFTime before supposed to interpret this data? It could be reverted to previous version.

@mbiesiad
Copy link
Author

mbiesiad commented Dec 8, 2024

Last comment from me today I hope:
"Top 10 countries by team count
US US — 5960
IN IN — 5252
RU RU — 2322
CN CN — 1707
FR FR — 1671
ID ID — 1552
VN VN — 1489
DE DE — 1162
KR KR — 1151
JP JP — 1151
999 teams total"

What data is correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants