Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only apply correction algorithms / gain selection if not yet applied by EVB #101

Open
maxnoe opened this issue Apr 22, 2021 · 3 comments
Open

Comments

@maxnoe
Copy link
Member

maxnoe commented Apr 22, 2021

Yesterday, the first data was taken with gain selection / deltaT correction applied by EVB.

We need smallish test data files for these conditions and need to implement.

@jsitarek
Copy link

Hi @maxnoe
in addition, I think it would be good to be able to force switching on or off the individual corrections via a config switch. I'm pretty sure that we will have some data in which the tagging of which correction is used will not be done properly (which seems to be the case already now).

@maxnoe
Copy link
Member Author

maxnoe commented Apr 29, 2021

@jsitarek Yes, I was about to add that. There is currently no way of knowing which algorithms have already been applied without relying on external information like the run log or the shifters.

@maxnoe
Copy link
Member Author

maxnoe commented Apr 29, 2021

Implemented in #102.

I will leave this issue open, because we need to look at this again, once the EVB actually writes information about what algorithms have already been applied into the events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants