Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename *Camera*Containers to *Telescope*Containers #2170

Open
StFroese opened this issue Dec 16, 2022 · 2 comments · May be fixed by #2204
Open

Rename *Camera*Containers to *Telescope*Containers #2170

StFroese opened this issue Dec 16, 2022 · 2 comments · May be fixed by #2204

Comments

@StFroese
Copy link
Member

StFroese commented Dec 16, 2022 •
edited
Loading

Yes, I'd go so far to rename most of the containers from camera to telescope. After all, we store them in .tel not .cam

Originally posted by @maxnoe in #2168 (comment)
@kosack
Copy link
Contributor

kosack commented Jan 4, 2023

Sounds good. The Camera name came from a time before there was a standard data model, so it's confusing. It will break some external code like LSTChain/NectarChain, but that is fine, just need to mark the PR as "breaking-change".

kosack added a commit that referenced this issue Jan 4, 2023
@kosack
Rename Containers 'Camera' to 'Telescope'
5a83848 
Fixes #2170
@kosack kosack mentioned this issue Jan 4, 2023
Closed
kosack added a commit that referenced this issue Jan 5, 2023
@kosack
Rename Containers 'Camera' to 'Telescope'
315343b 
Fixes #2170
@maxnoe maxnoe linked a pull request Jan 10, 2023 that will close this issue
First step of implementing CEP-002: Change container structure #2204
Open
@maxnoe
Copy link
Member

maxnoe commented Oct 21, 2023

This is done as part of #2204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@maxnoe @kosack @StFroese