From 4ffd39ed815538aafdef4acda34a5e4a634ae174 Mon Sep 17 00:00:00 2001
From: TjarkMiener <tjark.miener4692@googlemail.com>
Date: Mon, 26 Aug 2024 10:06:18 +0200
Subject: [PATCH] add unit tests for calculators

---
 src/ctapipe/monitoring/calculator.py          | 27 +++++++++----------
 .../monitoring/tests/test_calculator.py       |  2 +-
 2 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/src/ctapipe/monitoring/calculator.py b/src/ctapipe/monitoring/calculator.py
index 750e44cb75f..5249ab49a14 100644
--- a/src/ctapipe/monitoring/calculator.py
+++ b/src/ctapipe/monitoring/calculator.py
@@ -108,13 +108,13 @@ def __init__(
         self.outlier_detectors = {}
         if self.outlier_detector_list is not None:
             for outlier_detector in self.outlier_detector_list:
-                self.outlier_detectors[outlier_detector["apply_to"]] = (
-                    OutlierDetector.from_name(
-                        name=outlier_detector["name"],
-                        validity_range=outlier_detector["validity_range"],
-                        subarray=self.subarray,
-                        parent=self,
-                    )
+                self.outlier_detectors[
+                    outlier_detector["apply_to"]
+                ] = OutlierDetector.from_name(
+                    name=outlier_detector["name"],
+                    validity_range=outlier_detector["validity_range"],
+                    subarray=self.subarray,
+                    parent=self,
                 )
 
     @abstractmethod
@@ -197,7 +197,6 @@ def __call__(
         masked_pixels_of_sample=None,
         col_name="image",
     ) -> Table:
-
         # Check if the chunk_shift is set for second pass mode
         if self.second_pass and self.chunk_shift is None:
             raise ValueError(
@@ -222,7 +221,7 @@ def __call__(
                 chunk_shift=self.chunk_shift,
             )
 
-        # Detect faulty pixels with mutiple instances of ``OutlierDetector``
+        # Detect faulty pixels with multiple instances of ``OutlierDetector``
         outlier_mask = np.zeros_like(aggregated_stats["mean"], dtype=bool)
         for aggregated_val, outlier_detector in self.outlier_detectors.items():
             outlier_mask = np.logical_or(
@@ -270,7 +269,7 @@ def __call__(
                     slice_end = min(len(table) - 1, chunk_size * (index + 2)) - (
                         self.chunk_shift - 1
                     )
-                    # Slice the dl1 table according to the previously caluclated start and end.
+                    # Slice the dl1 table according to the previously calculated start and end.
                     table_sliced = table[slice_start:slice_end]
 
                     # Run the stats aggregator on the sliced dl1 table with a chunk_shift
@@ -285,7 +284,7 @@ def __call__(
                             chunk_shift=self.chunk_shift,
                         )
 
-                    # Detect faulty pixels with mutiple instances of OutlierDetector of the second pass
+                    # Detect faulty pixels with multiple instances of OutlierDetector of the second pass
                     outlier_mask_secondpass = np.zeros_like(
                         aggregated_stats_secondpass["mean"], dtype=bool
                     )
@@ -300,9 +299,9 @@ def __call__(
                             ),
                         )
                     # Add the outlier mask to the aggregated statistics
-                    aggregated_stats_secondpass["outlier_mask"] = (
-                        outlier_mask_secondpass
-                    )
+                    aggregated_stats_secondpass[
+                        "outlier_mask"
+                    ] = outlier_mask_secondpass
 
                     # Stack the aggregated statistics of the second pass to the first pass
                     aggregated_stats = vstack(
diff --git a/src/ctapipe/monitoring/tests/test_calculator.py b/src/ctapipe/monitoring/tests/test_calculator.py
index 2878e6d4a0f..08c818de0af 100644
--- a/src/ctapipe/monitoring/tests/test_calculator.py
+++ b/src/ctapipe/monitoring/tests/test_calculator.py
@@ -49,6 +49,7 @@ def test_onepass_calculator(example_subarray):
     # Check if three chunks are used for the computation of aggregated statistic values as the last chunk overflows
     assert len(stats) * 2 == len(stats_chunk_shift) + 1
 
+
 def test_secondpass_calculator(example_subarray):
     """test the chunk shift option and the boundary case for the last chunk"""
 
@@ -103,4 +104,3 @@ def test_secondpass_calculator(example_subarray):
     stats = calculator(ped_table, 1, col_name="image")
     # Check if the second pass was activated
     assert len(stats) > 20
-