Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

bug: blockquote styles not applied to LLM message markdown properly #58

Open
csells opened this issue Oct 22, 2024 · 6 comments
Open

bug: blockquote styles not applied to LLM message markdown properly #58

csells opened this issue Oct 22, 2024 · 6 comments
Labels
blocked blocked on something outside this repo bug Something isn't working
Milestone

Comments

@csells
Copy link
Owner

csells commented Oct 22, 2024

This is caused by this known issue, open since April of 2021: flutter/flutter#81720

There seems to be an PR to address this issue that wasn't merged: flutter/packages#4396

@csells csells added the bug Something isn't working label Oct 22, 2024
@csells
Copy link
Owner Author

csells commented Oct 22, 2024

@domesticmouse would you be willing to take a look at this? you were a reviewer on the PR. it's blocking proper formatting for the LLM messages of the Flutter AI Toolkit, which uses a MarkdownBody to show rich text output. Thanks!

@csells csells added this to the stable milestone Oct 22, 2024
@domesticmouse
Copy link

My commitment to this package is to make sure changes have test coverage. I don't actually know the code base. @gspencergoog may have thoughts on how to fix this.

@csells
Copy link
Owner Author

csells commented Oct 22, 2024

Thanks to both of you. The bug in question has a suggested fix.

@domesticmouse
Copy link

There seems to be an PR to address this issue that wasn't merged: flutter/packages#4396

There is no content in this PR.

The bug in question has a suggested fix.

I've put together flutter/packages#7927 with this fix applied, but the current tests don't pass. Can you debug? And add required tests for your use case?

@csells
Copy link
Owner Author

csells commented Oct 31, 2024

Thanks, @domesticmouse. I'll take a look ASAP.

@csells csells added the blocked blocked on something outside this repo label Nov 23, 2024
@csells
Copy link
Owner Author

csells commented Nov 27, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked blocked on something outside this repo bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants