Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS50P week 7 "Working 9 to 5": staff version accepts invalid format #231

Open
Richard-B-UK opened this issue Jan 30, 2024 · 0 comments
Open
Labels
CS50P CS50 Python

Comments

@Richard-B-UK
Copy link

"In a file called working.py, implement a function called convert that expects a str in either of the 12-hour formats below...

9:00 AM to 5:00 PM
9 AM to 5 PM"

In test_working.py, I tested various invalid formats including "09 AM to 09 PM", intending to raise a ValueError; but this test caused the staff version to fail (ie, the staff version of working.py accepts this format).

@rongxin-liu rongxin-liu added the CS50P CS50 Python label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CS50P CS50 Python
Projects
None yet
Development

No branches or pull requests

2 participants