Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove backup after deactivation #2

Open
michalpiekarski opened this issue Jul 10, 2023 · 2 comments
Open

Add option to remove backup after deactivation #2

michalpiekarski opened this issue Jul 10, 2023 · 2 comments

Comments

@michalpiekarski
Copy link

To reduce pollution of the workspace settings file, a configuration option should be added.
If set, the configuration backup will be removed after deactivating (successfully) the presentation mode.
This will incur small overhead due to the need for recreating the backup on each activation, but could help avoid unnecessary or unexpected, persistent modification of the workspace settings file.

@everdrone
Copy link

Same, my repos now all contain the backup file with "undefined" values

{
  "presentation-mode.configBackup": {
    "editor.lineHeight": "undefined",
    "editor.minimap.enabled": "undefined",
    "workbench.activityBar.visible": "undefined",
    "workbench.statusBar.visible": "undefined",
    "window.zoomLevel": "undefined"
  }
}

@brandoningli
Copy link

Echoing this request. Working in a team with a workspace settings file already, this makes the extension hard to justify using for the entire team since it clutters the file up.

If I have time sometime soon, I may attempt to implement this. Not being familiar with a framework hasn't stopped me yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants