Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch entirely to Textmesh Pro #108

Open
cs-util opened this issue Oct 10, 2023 · 0 comments
Open

Switch entirely to Textmesh Pro #108

cs-util opened this issue Oct 10, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cs-util
Copy link
Collaborator

cs-util commented Oct 10, 2023

Many of the UI components that cscore provides still use the old TextMesh and since its considered deprecated switch over entirely for all of these to Textmesh Pro. This would ensure performance improvements of all UIs and also better readability of the text elements. Please add a comment if you see any potential drawbacks with this.

The best backwards compatible way to do this that would not break existing projects using the current approach would be to introduce new prefabs that the current presenters could just switch to transparently.

And Textmesh Pro has to be added as a mandatory new dependency of cscore to the Unity manifest, which should be fine.

The main code change that would be needed is to extend the UI Link map with returning for text objects a generic wrapper interface (or maybe there is already a common interface between the Text and TextMesh Pro text classes?).
That approach would also allow developers who currently use the UI Link map for their own UIs to switch to text mesh Pro in their own UI prefabs at any time without having to change their code.

ThemeColor is another cscore component that needs to learn to work not only with Text instances but also with TextMesh Pro instances. The .ApplyColor method needs to be extended to support it.

I will prepare a draft on a new branch to make that idea more clear but won’t implement it for now.

@cs-util cs-util added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 10, 2023
cs-util added a commit that referenced this issue Nov 16, 2023
cs-util added a commit that referenced this issue Nov 16, 2023
cs-util added a commit that referenced this issue Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: To do
Development

No branches or pull requests

1 participant