Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, put all logic in vanilla JS files #18

Open
loket opened this issue Jan 15, 2021 · 1 comment
Open

Refactor, put all logic in vanilla JS files #18

loket opened this issue Jan 15, 2021 · 1 comment

Comments

@loket
Copy link
Member

loket commented Jan 15, 2021

It's a bit untidy to have all the logic in .njk files, and need to run eleventy in order to perform tests. It would be better if all the logic would be put in, say, app.js, and the generated output could be put in, say app.bundle.js (which could contain all the words).

This would also allow for testing with i.e. Jest (by adding a app.test.js file), which doesn't require a bunch words from another file to work.

@loket
Copy link
Member Author

loket commented Feb 15, 2022

Should consider inlining everything into one file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant