Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoip-enrich: remove filter #1184

Open
blotus opened this issue Dec 2, 2024 · 0 comments
Open

geoip-enrich: remove filter #1184

blotus opened this issue Dec 2, 2024 · 0 comments

Comments

@blotus
Copy link
Member

blotus commented Dec 2, 2024

We should remove the filter that was added some time go in the geoip-enrich parser:

  • The filter was added because crowdsec was logging an error if we did not manage to enrich the IP (eg, in the case the DB had no entry for the IP)
  • Due to a quirk in how parser stages are handled, if an event does not enter any parser in a given stage, it will be dropped and not reach the scenarios pipeline (which can be surprising in some situations, especially when writing scenarios that work with appsec rules).

The log spam was fixed in crowdsec, so we can remove the filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant