Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crowdsec] Log error that is returned from bucket pour #2790

Open
LaurenceJJones opened this issue Jan 27, 2024 · 3 comments · May be fixed by #3378
Open

[crowdsec] Log error that is returned from bucket pour #2790

LaurenceJJones opened this issue Jan 27, 2024 · 3 comments · May be fixed by #3378
Labels
needs/kind needs/triage

Comments

@LaurenceJJones
Copy link
Contributor

crowdsec/cmd/crowdsec/pour.go

Lines 43 to 47 in 91b0fce

poured, err := leaky.PourItemToHolders(parsed, holders, buckets)
if err != nil {
log.Errorf("bucketify failed for: %v", parsed)
continue
}

We eat this error without logging the error that happened? so we are clueless of what occurred
@github-actions GitHub Actions
Copy link

@LaurenceJJones: Thanks for opening an issue, it is currently awaiting triage.

In the meantime, you can:

  1. Check Crowdsec Documentation to see if your issue can be self resolved.
  2. You can also join our Discord.
  3. Check Releases to make sure your agent is on the latest version.
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions GitHub Actions
Copy link

@LaurenceJJones: There are no 'kind' label on this issue. You need a 'kind' label to start the triage process.

  • /kind feature
  • /kind enhancement
  • /kind bug
  • /kind packaging
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

crowdsec/pkg/leakybucket/manager_run.go

Lines 368 to 370 in 91b0fce

if err != nil {
return false, fmt.Errorf("failed to pour bucket: %w", err)
}

LaurenceJJones added a commit that referenced this issue Dec 23, 2024
@LaurenceJJones
fix: #2790
38940b4
@LaurenceJJones LaurenceJJones linked a pull request Dec 23, 2024 that will close this issue
Open
@LaurenceJJones LaurenceJJones linked a pull request Dec 23, 2024 that will close this issue
fix: Bucket pour log error with message #3378
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs/kind needs/triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Bucket pour log error with message crowdsecurity/crowdsec
1 participant
@LaurenceJJones