Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep upjet and other dependencies up-to-date #36

Closed
ulucinar opened this issue May 8, 2023 · 1 comment · Fixed by #69 · May be fixed by #51
Closed

Keep upjet and other dependencies up-to-date #36

ulucinar opened this issue May 8, 2023 · 1 comment · Fixed by #69 · May be fixed by #51
Labels
enhancement New feature or request

Comments

@ulucinar
Copy link
Collaborator

ulucinar commented May 8, 2023

What problem are you facing?

Currently, the https://github.com/upbound/upjet dependency in this repo needs to be updated manually. We had better consume the latest upjet in this repo so that latest bug fixes and features in upjet are available here and development of a new upjet-based provider (when this repo is forked) does not start with a relatively older version of upjet.

How could Upbound help solve your problem?

Can we employ a dependency management tool like renovate here also as we are already doing in the official provider repositories? Coupling this with #34, we would also make sure that this repository stays compatible with the latest version of upjet.

@displague
Copy link
Member

displague commented Feb 6, 2024

This issue should be updated to reflect that this is now a dependency on crossplane/upjet (#60 #59).

Updating to crossplane/upjet is more precarious now that it depends on go 1.21 while the rest of this project template hasn't been updated for 1.21.

Comparing against upbound/provider-aws, which is on 1.21, there are a number of improvements that can be made in the project.

#54 was the last attempt to update upjet in this template project. It unearthed potential problems in how the Shared RPC vs CLI would be used, would these continue to be blockers for an upjet 1.1.0 update?

As a provider contributor using upjet-provider-template as a base for improvements, I'm stuck. Each semi-regular attempt to update leads to build errors which require a deep dive into the upbound/build, angryjet, crossplane-runtime, kubernetes-runtime, golangci-lint, go tooling, and go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants