Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Clickable Labels for Checkbox Elements in resourcenav List #344

Open
1 task done
SisiVero opened this issue Oct 30, 2024 · 2 comments · May be fixed by #346 or #348
Open
1 task done

[Feature] Add Clickable Labels for Checkbox Elements in resourcenav List #344

SisiVero opened this issue Oct 30, 2024 · 2 comments · May be fixed by #346 or #348
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@SisiVero
Copy link
Contributor

Problem

Currently, the checkbox elements in the resourcenav filter list can only be selected by clicking on the checkbox itself, rather than on the associated label text. This creates a less intuitive experience for users who expect the label text to be clickable.

Description

This feature would allow users to select checkboxes by clicking on the associated label text. By adding unique id attributes to each checkbox and using the for attribute on the <label>, we can link each label to its checkbox. This approach will enable users to click either the checkbox or the label to toggle the checkbox state, improving accessibility and usability.

Alternatives

  • Wrapping the checkbox inside the element: This would also allow label-click toggling but may alter the HTML structure in a way that's less manageable.

  • Using JavaScript to toggle the checkbox state on label click: This could work without modifying the HTML, but it introduces additional complexity.

The proposed solution (using id and for attributes) keeps the HTML structure intact and aligns well with standard accessibility practices.

Additional context

Implementing this feature will improve the experience for users who expect clickable labels, making the interface more intuitive and accessible. Additionally, it aligns with best practices for form controls and accessibility standards.

Implementation

  • I would be interested in implementing this feature.
@SisiVero SisiVero added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 30, 2024
@akshaytyagi482
Copy link

i want to contribute on this kindly assign this to me

@possumbilities possumbilities added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 1, 2024
@SumaiyaaRq
Copy link
Contributor

Hi @akshaytyagi482 , please go through Contribution Guidelines — Creative Commons Open Source to know how issues and PRs are managed here .
Since the issue is ready for work now , you can work on it and go ahead with submitting a PR for it !
Hope that helps you !
All the best !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Status: Backlog
4 participants