Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The CC Vocabulary is not being used #178

Open
1 task done
kewonit opened this issue May 17, 2023 · 1 comment
Open
1 task done

[Bug] The CC Vocabulary is not being used #178

kewonit opened this issue May 17, 2023 · 1 comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@kewonit
Copy link

kewonit commented May 17, 2023

Description

After looking at fairly new merged pr #122, where instead of using the Vocabulary CDN, the entire global-header component has been hard-coded in.

Expectation

The Vocabulary CDN (for styles & scripts) should be imported in, over having them hard-coded in. As this will help follow the standards & guidance of Open source CC, also maintaining the repo will be ez!
This will fix many other issue that have been raised over time, regarding buggy UI.

Environment

  • Device: Laptop
  • OS: Ubuntu
  • Browser: Chrome
  • Version: 99.0.4844.84

Additional context

Importing them directly will make considerable changes, as it would try to overwrite the existing CSS, will have to fix them. The best way to fix this would be to import them in, and then remove the CSS that gets overwritten. Also, I would like to work on this issue.

Resolution

  • I would be interested in resolving this bug.
@kewonit kewonit added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels May 17, 2023
@possumbilities
Copy link
Contributor

@KewKartik The site doesn't currently utilize the Vocabulary CDN since the Vocabulary design system is under a refactor. At the moment it's most stable use is via unpkg and/or use through the Vue.js frontend framework, but even that is in flux.

For the time being, until the Vocabulary codebase is refactored fully there isn't an aim to implement it into the site yet. A similar approach was taken with the search repository as well.

I'm marking this as blocked, since it's something we'd hope to address, but after the Vocabulary codebase itself is in more stable condition for future use.

@possumbilities possumbilities added 🚧 status: blocked Blocked & therefore, not ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚧 status: blocked Blocked & therefore, not ready for work
Projects
Status: Backlog
Development

No branches or pull requests

2 participants