-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Upgrade project's JavaScript code with the power of ES6! for better performance. #110
Comments
we welcome and encourage anyone who is interested to contribute their insights and suggestions to this issue. Your input is highly valued and appreciated. |
This issue is similar to: |
This is similar to #17, but not quite a duplicate so I'm leaving it open. |
Thank you @possumbilities , |
@possumbilities I can see an unmerged PR for this issue. Can I work on this issue from the starting or It is solved ? |
@Murdock9803 Hi! something that could be helpful is testing the existing PR and commenting if you find any errors/if you don't. I think that's been the hold on that PR is it needed more thorough testing, and hasn't yet gotten it to a degree to fully be approved. |
@possumbilities |
Problem
Using these concepts can lead to more concise and readable code, with fewer bugs and better performance. Additionally, many of these concepts are supported by modern browsers and Node.js versions, making it easier to write code that can be run in multiple environments.
Description
There are several ways to improve the implementation, such as replacing all instances of var with const or let, implementing arrow functions, and ensuring that each function handles edge cases.
For eg:-
The function "getUrlVars()" declared in the "listing.html" file uses the "var" keyword for variable declaration, which may lead to variable scoping issues. Additionally, the code doesn't account for URL encoding of parameter values, which may cause incorrect capture of special characters. Moreover, the variable names used in the function are not very descriptive, which could make the code harder to comprehend and update.
Implementation
The text was updated successfully, but these errors were encountered: