Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Upgrade project's JavaScript code with the power of ES6! for better performance. #110

Open
1 task done
Keerthivardhan1 opened this issue Mar 24, 2023 · 7 comments · May be fixed by #167
Open
1 task done
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@Keerthivardhan1
Copy link
Contributor

Problem

Using these concepts can lead to more concise and readable code, with fewer bugs and better performance. Additionally, many of these concepts are supported by modern browsers and Node.js versions, making it easier to write code that can be run in multiple environments.

Description

There are several ways to improve the implementation, such as replacing all instances of var with const or let, implementing arrow functions, and ensuring that each function handles edge cases.

For eg:-

The function "getUrlVars()" declared in the "listing.html" file uses the "var" keyword for variable declaration, which may lead to variable scoping issues. Additionally, the code doesn't account for URL encoding of parameter values, which may cause incorrect capture of special characters. Moreover, the variable names used in the function are not very descriptive, which could make the code harder to comprehend and update.

Implementation

  • I would be interested in implementing this feature.
@Keerthivardhan1 Keerthivardhan1 added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Mar 24, 2023
@Keerthivardhan1
Copy link
Contributor Author

we welcome and encourage anyone who is interested to contribute their insights and suggestions to this issue. Your input is highly valued and appreciated.

@justaskulkarni
Copy link
Contributor

justaskulkarni commented Mar 29, 2023

This issue is similar to:

@possumbilities possumbilities added 🏁 status: ready for work Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Mar 31, 2023
@possumbilities
Copy link
Contributor

This is similar to #17, but not quite a duplicate so I'm leaving it open.

@Keerthivardhan1 Keerthivardhan1 linked a pull request Apr 3, 2023 that will close this issue
7 tasks
@Keerthivardhan1
Copy link
Contributor Author

Thank you @possumbilities ,
Based on my understanding I have optimized the JavaScript code .
This is the PR : - #167
Thanks a lot for letting me to work on this issue.

@Murdock9803
Copy link
Member

Murdock9803 commented Feb 21, 2024

@possumbilities I can see an unmerged PR for this issue. Can I work on this issue from the starting or It is solved ?

@possumbilities
Copy link
Contributor

@Murdock9803 Hi! something that could be helpful is testing the existing PR and commenting if you find any errors/if you don't. I think that's been the hold on that PR is it needed more thorough testing, and hasn't yet gotten it to a degree to fully be approved.

@Murdock9803
Copy link
Member

Murdock9803 commented Feb 29, 2024

@possumbilities
The PR looks fine and doesn't contain any errors, but it surely has merge conflicts due to merging of other commits after the PR got opened. Also, as PR #151 is merged, some functions got removed from the codebase. So it would be better if @Keerthivardhan1 resolves the merge conflicts by syncing the code. I can help with that too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants