Expose roots to afterRefresh hook. #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for direct manipulation of the DOM after you are done rendering it. Useful for focusing elements and other things.
This patch fixes a bug I experienced when working with contenteditable elements. It turns out that deleting the text of a contenteditable element causes the text node to be removed from the DOM and replaced with a <br> element instead. domChanger apparently does not expect text nodes to ever be removed by the browser, presumably because the contenteditable attribute either didn't exist or wasn't considered at the time of writing. So it continues to store a reference to the text node in its tree after it has been removed from the DOM. It will continue to update this node on subsequent renders, but the user will never see them as the node is no longer attached. This patch fixes that issue by not storing any references to text nodes at all, but instead by altering their contents using their parents' innerText property. This should work fine as there is only ever one text node per element and its value should always be the same as the value of innerText.
|
On the off chance you are still maintaining this project, this PR fixes some issues I was having with domChanger while using it recently. The first patch was a useful feature for me, but perhaps you can think of a better way of achieving the same thing. The second patch fixes what I consider to be a bug in domChanger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for direct manipulation of the DOM after you are done rendering it. Useful for focusing elements and other things.