Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tty handler error reporting #6

Open
cpuguy83 opened this issue Jan 24, 2023 · 0 comments
Open

Fix tty handler error reporting #6

cpuguy83 opened this issue Jan 24, 2023 · 0 comments

Comments

@cpuguy83
Copy link
Owner

The way errors are sent from the tty handler does not really work.
The wire format was supposed to be [sizeof(msg)][msg], however this was never implemented correctly and even had some compiler warnings (depending on what version/compiler was used).

Right now it is just writing the raw message to the socket... this can work if we close the connection down and then can just read to EOF... but I don't really like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant