-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
could you help to support bazel? #18
Comments
@sammi I have never used Could you give any insights of what is needed to be done to support Note, that |
@igagis, yes, bazel is a build system, each repo needs a WORKSPACE, your internal lib is a PACKAGE, which just need a bazel BUILD file to define it. Bazel will take care of the dependencies. I guess have a look its website could be helpful as well. Another sample you could check out is google test lib, which is using bazel as its official build tool. |
The main build system for all my libs is https://github.com/cppfw/prorab and I want to leave it so as it serves pretty well for my needs. But, I'm thinking of adding "side build systems" support to my libs, because I've also been requested to support for example CMake earlier. Also, I don't have time at the moment to implement and support those "side build systems" support, and likely will not ever have time for that, so if you could take the responsibility for |
@igagis, for bazel project, adding WORKSPACE and BUILD in the source tree would be its convention. Although add side folder would work, but it is not the natural way. I'd like help to support the bazel for you project. I hope I could get a PR ready soon. Oh wait, it seems that there are quite a few dependent libs are being managed by prorab, I guess choose bazel to build the lib would not be a trivial project, I may not be able to do it soon. |
@sammi yes, as I mentioned, there are a number of dependencies. Yes, I understand, that having those WORKSPACE and BUILD in source tree is natural for And this is what I asked you before, how does So, generally speaking, "managing" dependencies by just downloading source code snapshots is not practical because of the multiple levels of dependencies. |
@igagis, you just hit the weakness for bazel external dependencies management. It is quite bad to manage transitive deps at this moment, actually, bazel are introducing brand new external management mechanism by "bzlmod". https://docs.bazel.build/versions/main/bzlmod.html The idea is to use bazel_dep to manage dependencies, each module only care its own direct deps. |
@sammi looks good! So, when the feature is more stable then the libs can be adapted to |
Could you support bazel , so someone using bazel for their cpp project could import it in his WORKSPACE like:
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
name = "libstst",
urls = ["https://github.com/ccpfw/tst/archive/{sha256_hash_value}.zip"],
)
The text was updated successfully, but these errors were encountered: