Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Handle not found with required #83

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

quexpl
Copy link
Collaborator

@quexpl quexpl commented Dec 13, 2019

Fixes #82

@TwelveNights
Copy link

TwelveNights commented Mar 6, 2020

One question I have about your implementation is that, if the resource is a nested resource, is there a case in which we don't care if the parent exists? It seems to me that this "nested resource" would not be really nested if the parent ends up being nil.

I guess the issue is that we don't know if a resource is a parent or not unless we use another keyword, though.

Anyways, great PR :)

@quexpl
Copy link
Collaborator Author

quexpl commented Mar 18, 2020

I've explained it a bit in related issue #82

Copy link
Owner

@cpjk cpjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quexpl Hey! I'm no longer actively working in Elixir, so I'm not actively maintaining this project. I added a notice to the README, but it was committed the same day you opened this PR 🤦 . Sorry to take so long to look at this.

This PR looks good to me, but I haven't tested it!

How would you feel about me adding you as a maintainer? Like I said, I'm not actively maintaining this project, so I would be grateful to have you take it over!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The parent nested resource does not handle errors
3 participants