-
Notifications
You must be signed in to change notification settings - Fork 51
Handle not found with required #83
base: master
Are you sure you want to change the base?
Conversation
One question I have about your implementation is that, if the resource is a nested resource, is there a case in which we don't care if the parent exists? It seems to me that this "nested resource" would not be really nested if the parent ends up being I guess the issue is that we don't know if a resource is a parent or not unless we use another keyword, though. Anyways, great PR :) |
I've explained it a bit in related issue #82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quexpl Hey! I'm no longer actively working in Elixir, so I'm not actively maintaining this project. I added a notice to the README, but it was committed the same day you opened this PR 🤦 . Sorry to take so long to look at this.
This PR looks good to me, but I haven't tested it!
How would you feel about me adding you as a maintainer? Like I said, I'm not actively maintaining this project, so I would be grateful to have you take it over!
Fixes #82