Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DBIx::Class::Schema::Config for database config files #3

Open
preaction opened this issue Nov 22, 2016 · 0 comments
Open

Use DBIx::Class::Schema::Config for database config files #3

preaction opened this issue Nov 22, 2016 · 0 comments

Comments

@preaction
Copy link
Member

preaction commented Nov 22, 2016

Right now we're using the configuration system built-in to DBD::mysql called mysql_read_default_file. The database information and credentials are stored in ~/.cpanstats.cnf and are put there by the cpantesters-deploy Rexfile. This works fine, but only for MySQL. Other databases need their own way of handling credentials, which many of them simply don't have, putting the onus on us.

The DBIx::Class::Schema::Config module provides this configuration feature for all database drivers. We should use this module and provide the appropriate configuration files in a read-only area of the machine. Edits will also need to be made to the the cpantesters-deploy Rexfile to deploy this new configuration file.

Once this is done, we can remove the connect_from_config method in the existing CPAN::Testers::Schema class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant