Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PASS_IDENTIFIER and TEAM_IDENTIFIER is not configurable #138

Open
D-04 opened this issue Dec 10, 2021 · 0 comments
Open

PASS_IDENTIFIER and TEAM_IDENTIFIER is not configurable #138

D-04 opened this issue Dec 10, 2021 · 0 comments
Labels
enhancement New feature or request priority:low

Comments

@D-04
Copy link

D-04 commented Dec 10, 2021

PASS_IDENTIFIER and TEAM_IDENTIFIER seem to be hardcoded.

public static PASS_IDENTIFIER = 'pass.de.marvinsextro.covidpass'
public static TEAM_IDENTIFIER = 'X8Q7Q2RLTD'

When providing your own Apple Developer certificate Safari will decline the wallet saying: "Safari cannot download this file" since the PASS_IDENTIFIER and TEAM_IDENTIFIER don't match the certificate.

The current workaround for this is adapting these variables by hand and building the repository. However, it would be better if these constants could be configurable through environment variables. These environments variables can then also be set in the docker-compose file.

@marvinsxtr marvinsxtr added enhancement New feature or request priority:low labels Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low
Projects
None yet
Development

No branches or pull requests

2 participants