Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several region code updates #70

Open
burnside opened this issue Sep 13, 2020 · 0 comments
Open

Several region code updates #70

burnside opened this issue Sep 13, 2020 · 0 comments

Comments

@burnside
Copy link

burnside commented Sep 13, 2020

There are two "05" regions for CY, I believe Keryneia should be 06:

    CY_04(Country.CY, "Ammochostos"),
    CY_05(Country.CY, "Keryneia"),
    CY_03(Country.CY, "Larnaka"),
    CY_01(Country.CY, "Lefkosia"),
    CY_02(Country.CY, "Lemesos"),
    CY_05(Country.CY, "Pafos"),

And two "34" regions for DO, Nordeste should be 33:

    DO_02(Country.DO, "Cibao Central"),
    DO_37(Country.DO, "Del Valle"),
    DO_01(Country.DO, "Distrito Nacional"),
    DO_38(Country.DO, "Enriquillo"),
    DO_04(Country.DO, "Norcentral"),
    DO_34(Country.DO, "Nordeste"),
    DO_34(Country.DO, "Noroeste"),
    DO_35(Country.DO, "Norte"),
    DO_42(Country.DO, "Valdesia"),

The EG region code for "Giza" should be GZ, not SUZ: Wikipedia EG

EG_SUZ(Country.EG, "Giza"),

Two region codes in FJ are off. Bua should be 02, Serua should be 13:

    FJ_01(Country.FJ, "Ba"),
    FJ_01(Country.FJ, "Bua"),
    FJ_03(Country.FJ, "Cakaudrove"),
    FJ_04(Country.FJ, "Kadavu"),
    FJ_05(Country.FJ, "Lau"),
    FJ_06(Country.FJ, "Lomaiviti"),
    FJ_07(Country.FJ, "Macuata"),
    FJ_08(Country.FJ, "Nadroga and Navosa"),
    FJ_09(Country.FJ, "Naitasiri"),
    FJ_10(Country.FJ, "Namosi"),
    FJ_011(Country.FJ, "Ra"),
    FJ_12(Country.FJ, "Rewa"),
    FJ_R(Country.FJ, "Rotuma"),
    FJ_12(Country.FJ, "Serua"),
    FJ_14(Country.FJ, "Tailevu"),

Many of the GH country codes that are undefined can be filled in using:

    GH_AF(Country.GH, "Ahafo"),
    GH_AH(Country.GH, "Ashanti"),
    GH_BO(Country.GH, "Bono"),
    GH_BE(Country.GH, "Bono East"),
    GH_CP(Country.GH, "Central"),
    GH_EP(Country.GH, "Eastern"),
    GH_AA(Country.GH, "Greater Accra"),
    GH_NP(Country.GH, "Northern"),
    GH_NE(Country.GH, "North East"),
    GH_OT(Country.GH, "Oti"),
    GH_SV(Country.GH, "Savannah"),
    GH_UE(Country.GH, "Upper East"),
    GH_UW(Country.GH, "Upper West"),
    GH_TV(Country.GH, "Volta"),
    GH_WP(Country.GH, "Western"),
    GH_WN(Country.GH, "Western North"),

KR has a redundant region 28, the latter (Kwangju-Kwangyokshi) doesn't seem to be an official entry:

    KR_46(Country.KR, "Chollanam-do"),
    KR_28(Country.KR, "Inch'on-Kwangyokhi"),
    KR_42(Country.KR, "Kang-won-do"),
    KR_28(Country.KR, "Kwangju-Kwangyokshi"),
    KR_41(Country.KR, "Kyonggi-do"),
    KR_47(Country.KR, "Kyongsangbuk-do"),

LY has a redundant region JA, Al Jafārah should be JI: Wikipedia LY

    LY_BU(Country.LY, "Al Buţnān"),
    LY_JA(Country.LY, "Al Jabal al Akhḑar"),
    LY_JG(Country.LY, "Al Jabal al Gharbī"),
    LY_JA(Country.LY, "Al Jafārah"),
    LY_JU(Country.LY, "Al Jufrah"),

MK Caska should be 80, not 02
MK Radovis should be 64 (it is empty?)

MV Kaafu should be 26 not 29

MN Dzavhan should be 057 not 065

PW Sonsoral should be 370 not 350

PR has no official regional codes - probably several others are in a similar situation - for those I'd suggest just giving them numbered region codes? even if you want to be able to tell they are undefined you could use "undefXX" where XX increments or something so the region codes can still be used as keys in arrays, etc.

SI Litija should be 060 not 068
SI Tisina should be 010 not 128

TH Phetchabun should be 67 not 76

SJ may be worth a country entry? Wikipedia SJ

US is missing region code UM "Minor Outlying Islands"

All found while trying to convert the list to a set of java enums.

Hope that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant