Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could reduce restatement of COSE requirements #41

Open
laurencelundblade opened this issue Oct 12, 2023 · 0 comments
Open

Could reduce restatement of COSE requirements #41

laurencelundblade opened this issue Oct 12, 2023 · 0 comments

Comments

@laurencelundblade
Copy link
Contributor

There's a number of places where COSE requirements are unnecessary restated, referenced, repeated. I think they can be removed and the document would be shorter and more clear. COSE-HPKE doesn't change these characteristics of COSE. When they are restated, there's the risk of restating them wrong or leading the reader to think there's something different when there isn't.

  • All discussion of CBOR tags can be removed
  • All discussion of detached vs inline payload can be removed
  • The CDDL for a COSE_SIgn1 can be removed (sufficient to say that HPKE-base provides no auth)
  • There's some restatement on how Enc_structure works. It is exactly the same as COSE, right? It really needs to be.
  • There's restatement of how external_aad works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant