Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default label to name in text radiate geom (and maybe axis geom) #56

Open
corybrunson opened this issue Jun 10, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@corybrunson
Copy link
Owner

Usually a user will want to label radiating arrows with associated names, which will usually have been extracted from the ordination model as the name annotation column of the appropriate matrix. Almost never will a user want to label them with anything else except a variable they've manually constructed, in which case explicitly passing it to label will not only be necessary anyway but also make the code read more clearly. So GeomTextRadiate$default_aes should include label = name.

This should also perhaps apply to GeomAxis.

Finally, it may be appropriate to combine GeomVector and GeomTextRadiate into a single geom with distinguishable aesthetics, much as GeomAxis generates axes, tick marks, tick text, and axis labels. It would be possible to generate vectors without radiating text and radiating text without vectors, but this would require an explicit directive, e.g. label = "". Feedback is welcome on this.

@corybrunson corybrunson added the enhancement New feature or request label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant