Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-diff shows at most 10 warnings #10

Open
bgilbert opened this issue Jan 11, 2023 · 0 comments
Open

check-diff shows at most 10 warnings #10

bgilbert opened this issue Jan 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@bgilbert
Copy link
Contributor

GitHub renders at most 10 annotations in the PR diff view and the workflow run summary page. An unlimited number of warnings is shown in the check-diff job log, but the log is less ergonomic, so usually it's not used when a reviewer is examining the diff. Thus it's possible that a reviewer might miss some changes.

Clearly indicate that some warnings have been elided, perhaps by emitting at most 9 warnings plus a notice to check the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant