Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI - Mounting holes incorrect in output. #63

Open
algocrypto opened this issue Mar 28, 2024 · 9 comments
Open

GUI - Mounting holes incorrect in output. #63

algocrypto opened this issue Mar 28, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@algocrypto
Copy link

Hello,

It seems that the mounting holes paramater is not working on GUI, if I select 5 holes or any number of holes, the output is always 6 holes.

Please refer to the attached screenshot.

Am I missing something or does this look like a bug?

Cheers!!

image

@cooked
Copy link
Owner

cooked commented Mar 29, 2024

Hi @algocrypto,
have a look at the installation section of the README file and give it a try to one of the two "manual installation" methods.
It seems you're on the plugin version from the package manager, which has now fallen behind, while the code from the repo contains the fixes you need.

Before installing the new version make sure to remove the one installed via Package Manager.

The update possibly solves also #64

@cooked cooked added the bug Something isn't working label Mar 29, 2024
@algocrypto
Copy link
Author

algocrypto commented Mar 30, 2024

Hi @cooked ,
Thank you for the quick update.
I have uninstalled the plugin using package manager and installed the new plugin version 0.1.2 manually as per the instructions.
In this PCB I need 3 mounting holes, but as you see in the payout there are 6 mounting holes created. It looks like there is some hard coding done for the mounting holes and it does not consider the GUI input.
The problem still exist and I do not see any changes. Please refer to the attached screenshot for the PCB generated from the new version of the plugin.
Cheers !
Screenshot 2024-03-30 at 7 35 14 AM

@algocrypto
Copy link
Author

algocrypto commented Mar 31, 2024

Hi @cooked ,

Thank you for the quick updates.

I have tried both manual and package manager installation, and I still getting the old GUI, please see the attached screeshot

I have tried to restart KiCAD and reinstall, but same results.

It looks like the kimotor_gui is not updated on github, I only see the update done on kimotor_action.py file on guthub

Screenshot 2024-03-31 at 9 28 16 AM

@algocrypto
Copy link
Author

algocrypto commented Mar 31, 2024 via email

@cooked
Copy link
Owner

cooked commented Apr 27, 2024

Hi @algocrypto,
sorry for keeping you wait. Forget about the whole GUI thing, that was a problem on my end.

I've hopefully fixed the code to allow for any MH count when "Circle" outline is selected. This might bring up new issues, where you have to pay attention that the MH generated do not overlap with motor terminal (that was the reason to have them fixed to 6 before).

As a side note, in case you want to try other outline geometries, keep in mind that:

  • if the nr of MH selected in the GUI is 0 no MH is generated
  • if the nr of MH selected in the GUI is > 0, the nr of MH generated will be always equal to the nr of edges of the outline
    Again, this is to avoid, outline + MH crazy scenarios (that shall be handled manually then)

Let me know if that works for you.

@algocrypto
Copy link
Author

Thank you @cooked for the update, the new GUI seems to be working for me now and I am able to get desired MH.
But I am seeing other issues, for example, the via connector is always less, I tried to increase the track width expecting to have larger via holes. FYI, JLCPCB prefer to have 0.3/0.45 via holes else they have extra charges for PCB fabrication. I am still getting errors for via holes and many warning messages that the track is not connected. I think we are almost near the finish line for Kimotor plugin and I hope you will be able to fix it soon.
Once again thank you for all the help.

@cooked
Copy link
Owner

cooked commented Jun 9, 2024

Hi @algocrypto
with the latest commit I've introduced a little change that hopefully will simplify and improve reliability of the workflow.
Based on PCB preset dropdown the following will happen if these are selected:

  1. DRC rules: track width, clearances and via drill/hole (and annular width) are calculated based on the min allowed by DRC constraints
  2. Current T/V: track and via settings used are the current ones from the lists in the kicad GUI. other parameters are derived and checked against DRC constraints.

Default workflow for me is to select DRC rules as Kimotor PCB preset and in Kicad's Board Setup > Design rules > Constraints input all the geometrical parameters I want. If those match the JLCPCB requirements then the PCB motor should be compliant too.

Note that there might still be warnings related to silkscreen. For the time being I suggest you to move text around manually, if needed.

looking fwd to your feedback

@Katchyuser
Copy link

Awesome, Thank you @cooked , Let me check it out today and get back to you. I hope to complete the Stator design soon since it is delayed for long time and I am eager to test the new Axial Flux generator.

@Katchyuser
Copy link

Thank you @cooked , The DRC - Annular width error is resolved for me..I have submitted the PCB stator design to JLCPCB for review, I will let you know if there is any other issue. I really Appreciate your help and support to the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants