Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable k8s labels that align CSI for grouping logging #8

Open
sajayantony opened this issue Apr 13, 2023 · 2 comments
Open

Enable k8s labels that align CSI for grouping logging #8

sajayantony opened this issue Apr 13, 2023 · 2 comments

Comments

@sajayantony
Copy link
Collaborator

sajayantony commented Apr 13, 2023

Grouping the labels enables us to query for all pods from components that might be a part of the CSI driver.

For e.g.

kubectl logs --follow $(kubectl get pods -l 'app.kubernetes.io/name=csi-hostpathplugin' --all-namespaces -o jsonpath='{.items[*].metadata.name}')

Basically update the chart/deployments to componentized labels.

  labels:
    app.kubernetes.io/instance: csi.oras.land 
    app.kubernetes.io/part-of: csi-driver-oras
    app.kubernetes.io/name: csi.oras.land
    app.kubernetes.io/component: oras-csi-driver

See - main...sajayantony:oras-csi:labels#diff-a8700dba16974edcf2b009ae853444d94109db94d7538ea2038d72ae2966f68b

@vsoch
Copy link
Member

vsoch commented Apr 15, 2023

This will be added with my next PR (already done locally!)

@vsoch
Copy link
Member

vsoch commented Apr 15, 2023

@sajayantony I did some more testing, and when I added instance/name it strangely made two versions of the plugin driver pod, one with the name oras-oci-node-xxxx and the other oras.oci.land-xxx. I think it likely is that the developer isn't supposed to define the label (name or instance?) along with metadata: name, so for the time being I'm just going to add part-of for the filter, and we can look into debugging this further after these first early PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants