Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamiltonian flows #13

Open
jbcaillau opened this issue Oct 31, 2023 · 4 comments
Open

Hamiltonian flows #13

jbcaillau opened this issue Oct 31, 2023 · 4 comments
Assignees

Comments

@jbcaillau
Copy link
Member

jbcaillau commented Oct 31, 2023

@ocots The previous package to compute Hamiltonian flows is deprecated, is it OK to use stuff from this package and hamiltonian.jl to retrieve the same functionality (= flow of a Hamiltonian, not of an ocp with a given maximising control)?

Seems to be OK from the code, not in the documentation. Any example somewhere?

@ocots
Copy link
Member

ocots commented Nov 2, 2023

We can of course compute a flow from a Hamiltonian. Some doc is needed indeed.

@ocots
Copy link
Member

ocots commented Nov 2, 2023

See here for examples: https://github.com/control-toolbox/CTFlows.jl/blob/main/test/test_flow_hamiltonian.jl

@ocots
Copy link
Member

ocots commented Nov 2, 2023

I repeat that we need to define an AbstractFlowModel with methods and use it to define flows. It permits to write a generic code and to instantiate many computations of flows simply defining a subtype of the abstract type and new to overload the methods.

Like this we can benefit from the concatenate function, plot and more.

If a user wants to define its own flow he can. It is a nice feature to develop new algorithms.

@jbcaillau
Copy link
Member Author

@ocots thanks for the pointer to the tests (should've checked.) neat.

agree about having an abstraction for flows: any open issue on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants