Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 Proposal - Number input component #2160

Open
bgutsol opened this issue Aug 9, 2022 · 3 comments
Open

💡 Proposal - Number input component #2160

bgutsol opened this issue Aug 9, 2022 · 3 comments
Assignees
@denkristoffer @Lelith @burakukula @mshaaban0
Labels
needs review Proposal/bug that needs to be reviewed by maintainers proposal stale Used to mark when there was no activity for a set period of time

Comments

@bgutsol
Copy link
Contributor

bgutsol commented Aug 9, 2022

Forma 36 contribution proposal

The problem

We provide only native input with type="number". But due to different browsers' implementation and known issue with React onChange callback (facebook/react#6556) it's worth replicating the native number input logic with input type="text".

The proposed solution

Create a separate Number component that will replicate native number input validation and a11y controls.
We've already implemented it in our field-editor-number:
contentful/field-editors#1203

Breaking changes

NO.
@bgutsol bgutsol added proposal needs review Proposal/bug that needs to be reviewed by maintainers labels Aug 9, 2022
@denkristoffer
Copy link
Collaborator

Can we move the field editor over or is there additional work to be done?

@bgutsol
Copy link
Contributor Author

bgutsol commented Aug 26, 2022

Some adjusments need to be done to make it more generic and flexible.

@github-actions
Copy link

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denkristoffer denkristoffer

@Lelith Lelith

@burakukula burakukula

@mshaaban0 mshaaban0

Labels
needs review Proposal/bug that needs to be reviewed by maintainers proposal stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@denkristoffer @Lelith @burakukula @mshaaban0 @bgutsol