Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 Proposal - Don't allow modals to overflow the view port height #2073

Open
burakukula opened this issue Jun 2, 2022 · 2 comments
Open

💡 Proposal - Don't allow modals to overflow the view port height #2073

burakukula opened this issue Jun 2, 2022 · 2 comments
Assignees
@fabe
Labels
needs design review Proposal contains visual/ux changes needs review Proposal/bug that needs to be reviewed by maintainers proposal stale Used to mark when there was no activity for a set period of time

Comments

@burakukula
Copy link
Contributor

Discussed in https://github.com/contentful/forma-36/discussions/1003

Originally posted by damann May 12, 2021

Don't allow modals to overflow the view port height

The proposed solution

Remove the property allowHeightOverflow

Breaking changes

Yes
@burakukula burakukula added proposal needs review Proposal/bug that needs to be reviewed by maintainers needs design review Proposal contains visual/ux changes labels Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Marking issue as stale since there was no acitivty for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Aug 5, 2022
@Lelith Lelith assigned Lelith and fabe and unassigned Lelith Sep 14, 2022
@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Sep 15, 2022
@github-actions
Copy link

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabe fabe

Labels
needs design review Proposal contains visual/ux changes needs review Proposal/bug that needs to be reviewed by maintainers proposal stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Lelith @burakukula @fabe