Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 Proposal - hidden=until-found attribute to accordion / collapse component #2043

Open
YvesRijckaert opened this issue May 4, 2022 · 2 comments
Open

💡 Proposal - hidden=until-found attribute to accordion / collapse component #2043

YvesRijckaert opened this issue May 4, 2022 · 2 comments
Assignees
@denkristoffer @Lelith @burakukula @mshaaban0 @domarku
Labels
needs review Proposal/bug that needs to be reviewed by maintainers proposal stale Used to mark when there was no activity for a set period of time

Comments

@YvesRijckaert
Copy link
Contributor

Forma 36 contribution proposal

The problem

The find-in-page functionality does currently not work with collapsed content.

The proposed solution

The new hidden=until-found attribute and beforematch event, auto-opens section on text find. (Currently only works in Chromium 102), but it is part of the HTML spec.
This would be a great progressive enhancement, so in browsers that do not support the new attribute and event, the components will still work.

I would be happy to make this change.

More info

https://developer.chrome.com/blog/hidden-until-found/
@YvesRijckaert YvesRijckaert added proposal needs review Proposal/bug that needs to be reviewed by maintainers labels May 4, 2022
@burakukula
Copy link
Contributor

@YvesRijckaert yeah! Let's do it! Would be great if you have some time to introduce this change 🙌
If we can do it as part of the component that would be great, let's not create an additional prop for it.

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Marking issue as stale since there was no acitivty for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Aug 7, 2022
@Lelith Lelith mentioned this issue Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denkristoffer denkristoffer

@Lelith Lelith

@burakukula burakukula

@mshaaban0 mshaaban0

@domarku domarku

Labels
needs review Proposal/bug that needs to be reviewed by maintainers proposal stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@denkristoffer @Lelith @burakukula @mshaaban0 @domarku @YvesRijckaert