Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Uppercase mount attributes to be compliant with Docker Py #486

Open
D3vil0p3r opened this issue Dec 19, 2024 · 1 comment · May be fixed by #487
Open

Support Uppercase mount attributes to be compliant with Docker Py #486

D3vil0p3r opened this issue Dec 19, 2024 · 1 comment · May be fixed by #487

Comments

@D3vil0p3r
Copy link

Currently docker py uses Mount attributes that start with uppercase letter (ref. https://github.com/docker/docker-py/blob/03e43be6af9b21f9f966eb84ca46a159b664ccf4/docker/types/services.py#L253).

A docker mount example list variable is like:

mounts: [{'Target': '/.exegol/spawn.sh', 'Source': '/home/athena/Exegol/exegol/utils/imgsync/spawn.sh', 'Type': 'bind', 'ReadOnly': True}, {'Target': '/tmp/.X11-unix', 'Source': '/tmp/.X11-unix', 'Type': 'bind', 'ReadOnly': False}, {'Target': '/etc/localtime', 'Source': '/etc/localtime', 'Type': 'bind', 'ReadOnly': True}, {'Target': '/opt/my-resources', 'Source': '/home/athena/.exegol/my-resources', 'Type': 'bind', 'ReadOnly': False}, {'Target': '/opt/resources', 'Source': '/home/athena/Exegol/exegol-resources', 'Type': 'bind', 'ReadOnly': False}, {'Target': '/workspace', 'Source': '/home/athena/.exegol/workspaces/default', 'Type': 'bind', 'ReadOnly': False}]

Currently it does not work in podman py.

Some projects using containers would use both Docker and Podman and, to avoid complex code, it could be useful if Podman can manage mount attributes as both lowercase and first-letter uppercase.

A solution could be normalize mount item keys when podman py mount receive input entries as the example above.
@D3vil0p3r D3vil0p3r linked a pull request Dec 19, 2024 that will close this issue
Open
@D3vil0p3r
Copy link
Author

#487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support uppercase mount attributes D3vil0p3r/podman-py
1 participant
@D3vil0p3r