Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codespelling tests no longer work #951

Closed
p12tic opened this issue May 26, 2024 · 1 comment · Fixed by #954
Closed

Codespelling tests no longer work #951

p12tic opened this issue May 26, 2024 · 1 comment · Fixed by #954
Labels
bug Something isn't working

Comments

@p12tic
Copy link
Collaborator

p12tic commented May 26, 2024

Per #950. Most likely codespelling action automatically updated. We should pin it to exact version and also have a word allowlist to address false positives.
@p12tic p12tic added the bug Something isn't working label May 26, 2024
@mokibit mokibit mentioned this issue May 28, 2024
Merged
@mokibit
Copy link
Contributor

mokibit commented May 28, 2024 •
edited
Loading

GitHub action actions-codespell@v2 uses codespell[toml]>=2.2.4 as a dependency.
Since specific version of codespell can not be chosen by a user of this action, newer versions of codespell can break tests as it happens in podman-compose.
There is a feature request in codespell-project/actions-codespell to add a possibility to specify the version of Codespell : codespell-project/actions-codespell#70.
For now, this PR adds a workaroud for breaking tests: adds ignore_words_file.
Fixed in #954.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

github/workflows: Fix automatic codespelling update mokibit/podman-compose
2 participants
@p12tic @mokibit