Bump rust version to resolve builds #223
Conversation
Use rust-toolchain.toml file over makefile installation. Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
bump-rust-version
branch
from
d1bb673 to
ce203fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 24.33% 24.97% +0.64%
==========================================
Files 16 16
Lines 2655 2651 -4
==========================================
+ Hits 646 662 +16
+ Misses 2009 1989 -20 ☔ View full report in Codecov by Sentry. |
Add convenient helper make function and use it in CI Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
bump-rust-version
branch
2 times, most recently
from
a02c225 to
4bfe9f9
Compare
Fix clippy suggestion Signed-off-by: James Sturtevant <[email protected]> Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
bump-rust-version
branch
from
4bfe9f9 to
8d8ac56
Compare
| @@ -0,0 +1,4 @@ | |||
| [toolchain] | |||
| channel="1.77.0" | |||
There was a problem hiding this comment.
I feel that it best not to pin in one version?
Or using https://doc.rust-lang.org/cargo/reference/manifest.html?#the-rust-version-field
There was a problem hiding this comment.
It was locked to a version in a previous PR: #179. Whic is causing the failures in #219
Using the toolchain file doesn't force that version, it just determines the toolchain to use if not already overridden. It be overridden via other commands: https://rust-lang.github.io/rustup/overrides.html.
I don't think the rust-version field helps with tool chain installation, but we can certainly set it as a minimal version. Any ideas on the what version it should be set to?
There was a problem hiding this comment.
added the min rust-version
There was a problem hiding this comment.
Thanks, LGTM.
The minnest version is the same as home v0.5.9.
error: package `home v0.5.9` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.66.1
Add a rust minimal version Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
bump-rust-version
branch
from
6295023 to
486b4e8
Compare
[v0.7] Backport of "Bump rust version to resolve builds" #223
Fixes #219
Switches to using https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file