Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update protobuf to the latest v3.5.1 version for both ttrpc-codegen and ttrpc-compiler #237

Open
Mossaka opened this issue Sep 21, 2024 · 0 comments

Comments

@Mossaka
Copy link
Member

Mossaka commented Sep 21, 2024

Is your feature request related to a problem? Please describe.

Projects like containerd/runwasi and containerd/rust-extensions all depend on ttrpc-rust and a quick cargo build --timings shows that they are compiling protobuf twice:

Image

Ideally, we would want to keep just one version of the protobuf, so there is this request.

Discussion

Also, I realized that ttrpc-codegen depends on ttrpc-compiler. I'd suggest to use a local path for local development and make this repo a Cargo workspace to reduce compilation time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant