feat: Add wasmtime http load test in the CI #770
Merged
+168
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
this adds a few new steps to the Benchmark job to report wasmtime HTTP throughput and latency results Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- Makefile: Language not supported
Comments skipped due to low confidence (3)
scripts/parse-hey.py:28
- [nitpick] The variable name 'rps' is ambiguous. It should be renamed to 'requests_per_second'.
rps = None
scripts/parse-hey.py:29
- [nitpick] The variable name 'lat' is ambiguous. It should be renamed to 'latency'.
lat = None
scripts/parse-hey.py:52
- The error message could be more user-friendly. Consider changing it to: 'Usage: python parse_hey.py <path_to_hey_output_file>'.
print("Usage: python parse_hey.py <hey-output-file>")
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
andreiltd
reviewed
Dec 11, 2024
andreiltd
approved these changes
Dec 11, 2024
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a HTTP load test using the CLI
heyto the CI workflow. Key changes include:test-image/httpandload/httptargets to the Makefile to create and load HTTP OCI image.crates/containerd-shim-wasmtime/README.mdimage reference for the wasmtime shim.hey.github/workflows/benchmarks.ymlto include steps for starting and stopping thewasmtimeshim running HTTP server and load tests, and report the result to the action.heyand format it as JSON for reporting HTTP RPS and p95 latency.