Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with uint8 conversion for float data in CopyVolume #37

Open
constantinpape opened this issue Apr 14, 2022 · 0 comments
Open

Fix issues with uint8 conversion for float data in CopyVolume #37

constantinpape opened this issue Apr 14, 2022 · 0 comments

Comments

@constantinpape
Copy link
Owner

The conversion to uint8 for float data in https://github.com/constantinpape/cluster_tools/blob/master/cluster_tools/copy_volume/copy_volume.py#L208-L214 is incorrect since it just normalizes based on the local statistics, which will lead to artifacts.
Instead we need to compute global min and max and pass it to the task for conversion without artifacts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@constantinpape