Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help requested in testing Codecov integration #36

Open
greg-1-anderson opened this issue Dec 7, 2020 · 2 comments
Open

Help requested in testing Codecov integration #36

greg-1-anderson opened this issue Dec 7, 2020 · 2 comments

Comments

@greg-1-anderson
Copy link
Member

Goal: Determine if Codecov integration is working well for PRs submitted by non-owners.

MVP: Open a PR that does anything / nothing and see the (unchanged) Codecov report.

Extra credit: Examine the Codecov report, find some code that is not covered, and write a test that increases coverage. Observe Codecov delta report.
@thomasrockhu thomasrockhu mentioned this issue Dec 7, 2020
Closed
@thomasrockhu
Copy link

@greg-1-anderson, one thing I noticed is that you aren't using the GitHub app integration. That might be causing issues with PRs submitted from forks (namely statuses and comments are missing)

@greg-1-anderson
Copy link
Member Author

Ah so I have learned even more! Thanks -- I thought that the bash script was equivalent to the GitHub app integration. I'll give that a spin and see if it works better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greg-1-anderson @thomasrockhu