Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax not updated for Electron 1.0? #110

Open
gadget00 opened this issue Jun 13, 2016 · 2 comments
Open

syntax not updated for Electron 1.0? #110

gadget00 opened this issue Jun 13, 2016 · 2 comments

Comments

@gadget00
Copy link

Hi; I believe this project is extremely helpful to lower the bar to start working on Electron. For that, thank you!

However, I just downloaded the pack and I am getting multiple errors of js when running the demo app, because of inconsistencies against the 'new' electron syntax. I managed to read the official electron documentation to at least fix the browserWindow error and it kinda loads, but now I'm getting some other errors that I have no idea(so far) how to address.

Does the github code has them corrected? I downloaded my zip file from the main website. Please let me know.

Again, thanks for your great work

@jdavidbakr
Copy link

I've replaced the top part of main.js to be:

var electron = require('electron')
const {app,BrowserWindow} = electron

(which I found from another Electron tutorial) and am not getting any errors, however I am getting two header bars.

Would love to see this package updated for Electron 1.0, I'm hoping it's not been abandoned.

@scholtzm
Copy link

Photon is "just a stylesheet". You can use it with latest version of Electron without any issues. The template app is outdated, but it only serves as an example (a non-working one in this case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants