Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate functionality? #7

Open
shibe-dev opened this issue Apr 1, 2021 · 0 comments
Open

duplicate functionality? #7

shibe-dev opened this issue Apr 1, 2021 · 0 comments

Comments

@shibe-dev
Copy link

shibe-dev commented Apr 1, 2021 •
edited
Loading

Hi - is there a reason theres duplicate functionality? setVault/changeVault seem to do the same thing. ChangeMPCOwner is also really similar, the only difference is that it's a public function instead of external
Link to code:
https://github.com/connext/chaindata/blob/main/AnyswapV4ERC20.sol#L203
https://github.com/connext/chaindata/blob/main/AnyswapV4ERC20.sol#L224
https://github.com/connext/chaindata/blob/main/AnyswapV4ERC20.sol#L232
@shibe-dev shibe-dev changed the title duplicate functionality duplicate functionality? Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shibe-dev