Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage for .js and .d.ts generated code #824

Open
timostamm opened this issue Sep 14, 2023 · 0 comments
Open

Improve test coverage for .js and .d.ts generated code #824

timostamm opened this issue Sep 14, 2023 · 0 comments
Labels
cleanup Cleanup tasks

Comments

@timostamm
Copy link
Member

timostamm commented Sep 14, 2023 •
edited
Loading

The TypeScript code generated by protoc-gen-connect-es is tested exhaustively in this repository. However, the plugin can also generate .js and .d.ts, and this code path is not under test.

To guard against regressions, we should put .js and .d.ts generated code under test as well, and make sure that generated code is under version control and reviewable.

For reference, protobuf-es generates both .js+.d.ts and .ts, and runs tests on both here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Cleanup tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timostamm