Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make agent listen on unix socket instead of all devices #18

Open
dcmiddle opened this issue Aug 10, 2022 · 6 comments
Open

make agent listen on unix socket instead of all devices #18

dcmiddle opened this issue Aug 10, 2022 · 6 comments
Assignees
Labels
epic New feature to develop

Comments

@dcmiddle
Copy link
Member

dcmiddle commented Aug 10, 2022

Occlum needs to add support for Unix Domain Sockets
Once that is added, update the agent...

Update src/enclave-agent/Cargo.toml to use upstream ttrpc instead of haosanzi's branch

ttrpc = { git = "https://github.com/haosanzi/ttrpc-rust", features = ["async"] }

Fix TODO comment in agent src/enclave-agent/src/main.rs
// TODO: will replace with unix socket
const SOCK_ADDR: &str = "tcp://0.0.0.0:7788";

@ariel-adam
Copy link
Member

@dcmiddle is this issue still relevant or can be closed?
If it's still relevant to what release do you think we should map it to (mid-November, end-December, mid-February etc...)?

@dcmiddle
Copy link
Member Author

target for after occlum 1.0 release at end of calendar year. This is a security enhancement and does not block current release features.

@hairongchen
Copy link
Contributor

one thing related is k8s needs liveness and readiness probe to determining the status of the container, will the agent in the future need to respond to these checks in addition to app specific liveness and readiness checks?

@mythi
Copy link
Contributor

mythi commented Nov 18, 2022

one thing related is k8s needs liveness and readiness probe to determining the status of the container, will the agent in the future need to respond to these checks in addition to app specific liveness and readiness checks?

no. the agent is opaque to kubernetes

@hairongchen
Copy link
Contributor

hairongchen commented Nov 18, 2022

nevertheless, though all considered infra structure containers, but not like pause container, agent enclave container has a running process, runtime still has the responsibility to make sure the enclave-agent is healthy and functional and take action upon agent process failure.

@mythi
Copy link
Contributor

mythi commented Nov 24, 2022

one additional thing that needs fixing here is: each pod gets a unique socket. currently, when running several pods they all have an agent that listen to the same address/port in the host network namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic New feature to develop
Projects
Status: No status
Development

No branches or pull requests

6 participants