-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The windows builds look really suspect #47
Comments
The referenced PR also removes a maintainer from the feedstock without any mentions on "why". |
@deslaughter could you please provide some more background here? Asking as it appears you are the author of PR ( #46 ), which is what Mark is asking about above |
@jakirkham, @hmaarrfk the OpenFAST developers have struggled for a long time to build this software on Windows using conda-forge. The main difficulty is finding a modern Fortran compiler for Windows as the default one is not compliant with the 2003 standard. Unfortunately, the LLVM Flang compiler, which is used by SciPy, is not yet ready for production use (did not successfully compile OpenFAST because it is missing features). The lack of a Fortran compiler on Windows seems like a known issue (conda-forge/conda-forge.github.io#1044). The best solution that I could find was to use the Intel oneAPI compiler. I agree that downloading the Intel oneAPI compiler in the @xhochy the maintainer was removed in the PR because he is no longer active on the project. I should have explained this change. |
This will be resolved in #51 |
Thank you for working to address it. 1 year later i find time to reply: The order in which things is done matters. You can explain your challenges, then ask if the proposal is OK to merge. Ultimately, some things are under different licenses and can introduce ABI incompatibility. When doing things that are strange you can contact Please try to communicate challenges in the future. |
Comment:
I'm wondering why the windows builds were merged in haste without discussions when previous questions were raised to @conda-forge/core regarding their incompatibility with the larger ecosystem.
Lines that download other executable such as this one
https://github.com/conda-forge/openfast-feedstock/pull/46/files#diff-54cf74e113dd3f6d11e092fdb1d888ec82c69bdafbb15cfb6570c83ecad28f33R3
Are not really OK in the conda-forge ecosystem.
I think it would have been important for that build to ping somebody from conda-forge/help-c-cpp to ensure that things are on the right track.
Please refrain for future merges to the conda-forge repository and lets wait for this particular discussion to be resolved.
Particularly, I am worried about downloading parts that are critical to the windows build in the
bld.bat
script.The text was updated successfully, but these errors were encountered: