Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default example doesn't work #1

Open
quadrismegistus opened this issue Jan 15, 2022 · 8 comments
Open

Default example doesn't work #1

quadrismegistus opened this issue Jan 15, 2022 · 8 comments

Comments

@quadrismegistus
Copy link

quadrismegistus commented Jan 15, 2022

Am I doing something wrong? I'm running the code exactly as in the readme.

(base) ryan@sisko~/etc/clippy 13:50:42 $ python clip.py art/sea/boats/small_boat_1/ 100 3 -c
sh: color: command not found
sh: cls: command not found
Traceback (most recent call last):
  File "clip.py", line 376, in <module>
    clippy(args.path, args.speed, args.cycles, args.color)
  File "clip.py", line 370, in clippy
    clip = Clip(path, speed, cycles, color)
  File "clip.py", line 205, in __init__
    raise ClipException("""
__main__.ClipException: 
                    Your folder specified by path, must contain a subfolder 
                    called 'ascii'. This ascii subfolder must contain at least 
                    1 txt file. Your folder hierarchy should look similar to:

                    C:.
                    └───art
                        ├───animals
                        ├───buildings
                        │   └───castles
                        ...     └───my_folder
                                    └───ascii
                                        └───my_art_1.txt
                                        └───my_art_2.txt
                                        ...
                                        ...
                                        └───my_art_n.txt

                    
(base) ryan@sisko~/etc/clippy 13:50:43 $ ls art/sea/boats/small_boat_1/ascii/
small_boat_1a.txt	small_boat_1d.txt	small_boat_1g.txt	small_boat_1j.txt	small_boat_1m.txt
small_boat_1b.txt	small_boat_1e.txt	small_boat_1h.txt	small_boat_1k.txt	small_boat_1n.txt
small_boat_1c.txt	small_boat_1f.txt	small_boat_1i.txt	small_boat_1l.txt	small_boat_1o.txt

Thanks for a cute and creative library!

@con-dog
Copy link
Owner

con-dog commented Jan 16, 2022

Hey there, what OS are you running on? I haven't looked at this in awhile, and I should've mentioned... I've only tested this in CMD

@quadrismegistus
Copy link
Author

Mac, though I could try it on my linux machine too.

@quadrismegistus
Copy link
Author

Yeah, same on linux.

ryan@ember:~/etc$ git clone https://github.com/con-dog/clippy
Cloning into 'clippy'...
remote: Enumerating objects: 232, done.
remote: Counting objects: 100% (65/65), done.
remote: Compressing objects: 100% (60/60), done.
remote: Total 232 (delta 46), reused 5 (delta 5), pack-reused 167
Receiving objects: 100% (232/232), 14.42 MiB | 10.04 MiB/s, done.
Resolving deltas: 100% (108/108), done.

ryan@ember:~/etc$ cd clippy/

ryan@ember:~/etc/clippy$ python clip.py art/sea/boats/small_boat_1/ 100 3 -c
sh: 1: color: not found
sh: 1: cls: not found
Traceback (most recent call last):
  File "clip.py", line 376, in <module>
    clippy(args.path, args.speed, args.cycles, args.color)
  File "clip.py", line 370, in clippy
    clip = Clip(path, speed, cycles, color)
  File "clip.py", line 205, in __init__
    raise ClipException("""
__main__.ClipException: 
                    Your folder specified by path, must contain a subfolder 
                    called 'ascii'. This ascii subfolder must contain at least 
                    1 txt file. Your folder hierarchy should look similar to:

                    C:.
                    └───art
                        ├───animals
                        ├───buildings
                        │   └───castles
                        ...     └───my_folder
                                    └───ascii
                                        └───my_art_1.txt
                                        └───my_art_2.txt
                                        ...
                                        ...
                                        └───my_art_n.txt

                    
ryan@ember:~/etc/clippy$ ls art/sea/boats/small_boat_1/ascii/
small_boat_1a.txt  small_boat_1e.txt  small_boat_1i.txt  small_boat_1m.txt
small_boat_1b.txt  small_boat_1f.txt  small_boat_1j.txt  small_boat_1n.txt
small_boat_1c.txt  small_boat_1g.txt  small_boat_1k.txt  small_boat_1o.txt
small_boat_1d.txt  small_boat_1h.txt  small_boat_1l.txt

@joshjetson
Copy link
Contributor

joshjetson commented Dec 19, 2023

same issue almost two years later unresolved. Im fixing it ill send a pull request. I am attempting to fix this for Linux/Unix based systems. I have narrowed down some the the issues and resolved the specified path issue. If you observe
sh: color: command not found
sh: cls: command not found
were also issues in the original comment which I also resolved.
Right now I am narrowing some issues down to stdout problems

@joshjetson
Copy link
Contributor

joshjetson commented Dec 19, 2023

Fixed it! The only issue is color. In linux the colors will not work in the default examples I can sort this out at a later date. There is also the minor issue of some of the examples not containing the proper sub directories mentioned in the repr , ie ascii and color folders. This is a neat little program and I hope Linux/Unix users can use it now. :-) Pull request sent

@con-dog
Copy link
Owner

con-dog commented Dec 19, 2023 via email

@joshjetson
Copy link
Contributor

Thanks! I haven’t looked at this project in a while but feel free to fork and merge at your will

On Wed, 20 Dec 2023 at 10:37 AM, joshjetson @.> wrote: Fixed it! The only issue is color. In linux the colors will not work in the default examples I can sort this out at a later date. There is also the minor issue of some of the examples not containing the proper sub directories mentioned in the repr , ie ascii and color folders. This is a neat little program and I hope Linux/Unix users can use it now. :-) — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR553ZVFPGUHDN7H5L7SXJLYKICKNAVCNFSM5MBAPSEKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBWGM2TANRZGA4A . You are receiving this because you commented.Message ID: @.>

I sent it your way my bro, pending your approval. :-) Cheers!

@joshjetson
Copy link
Contributor

Did you not want to merge into your branch ? You could check the diff I did not modify your original I just included a new file which is basically your application but modified to work on linux systems. There were some other issues too that I addressed an am surprised worked on a windows system. You were attempting to create instance attributes outside of the dunder init method. I would appreciate being able to be a contributior to the project by you merging the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants