Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Rules in AbstractInterpreter #80

Merged
merged 4 commits into from
Feb 18, 2024
Merged

Cache Rules in AbstractInterpreter #80

merged 4 commits into from
Feb 18, 2024

Conversation

willtebbutt
Copy link
Member

If a rule has already been derived, don't re-derived it, just look it up from a cache of rules.

@yebai
Copy link
Contributor

yebai commented Feb 14, 2024

Good one -- it's strange that some tests fail with cached rules.

@willtebbutt
Copy link
Member Author

There's quite a lot of state associated to the object returned by build_rrule!!, so the test failures mean that something isn't composing properly there at the minute. 🤞 it's something simple.

@willtebbutt willtebbutt merged commit 0376c00 into main Feb 18, 2024
11 checks passed
@willtebbutt willtebbutt deleted the wct/cache-rules branch February 18, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants