Eager Instruction Creation #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Completely redundant -- closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the instructions are constructed when-needed. This is helpful for avoiding things which are a little awkward to construct, but has a run-time hit associated to checking whether each instruction is / is-not assigned each time it is encountered.
This PR will attempt to modify this. It necessarily taxes the robustness of our system further, because it requires that any instruction we encounter can be constructed. The basic tests pass locally for the interpreted function as-is, so I'm opening this PR to see whether the integration tests also pass. Presumably they won't.