Update ctkLogger #1181
Merged
Update ctkLogger #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that we removed support for Qt4, for new classes, I think we should instead standardize on using |
This revisits the order of the `ctkErrorLogLevel` enum values to align with the typical log level hierarchy—from verbose (i.e., Debug) to less verbose (i.e., Critical). The "None" value has been moved to the end of the enum to ensure it holds the largest value. Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
Set ctkLogger default level is set based on the build configuration. If a Debug build, the default log level is set as `ctkErrorLogLevel::LogLevel::Debug` and it set as `ctkErrorLogLevel::LogLevel::Warning` otherwise. The mapping of the logger functions is the following: * `ctkLogger::trace()` -> `qDebug() * `ctkLogger::debug()` -> `qDebug()` * `ctkLogger::info()` -> `qInfo()` * `ctkLogger::warn()` -> `qWarning()` * `ctkLogger::error()` -> `qCritical()` * `ctkLogger::fatal()` -> `qCritical()` For convenience, the order of the function declaration has been updated to match the ordering of log level (Trace < Fatal). Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
jcfr
force-pushed
the
update-ctkLogger
branch
from
2a8f6e1 to
356fb51
Compare
|
I revisited the default level associated with the ctkLogger functions and also added a multiple tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctkLoggeradding support for log level: Set default level based on the build config.ctkErrorLogLevelenum values defining "Unknown" as 0