Issue #5876 - Fix filename conflict issue by appending numbers in parentheses #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @junnzhuu the code that generates the number changed a bit, which means there is now a conflict... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #5876 by modifying the filename conflict resolution.
Previously, numbers were appended directly to filenames which could alter their meaning.
Now, the numbers are enclosed in parentheses to avoid changing the original meaning.
Changes made:
findUniqueFileNameinUploadWorker.ktto append sequence numbers in parentheses.Tested the changes with multiple uploads, and filenames are now correctly generated.