Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename millSourcePath #4111

Open
lihaoyi opened this issue Dec 11, 2024 · 1 comment
Open

Rename millSourcePath #4111

lihaoyi opened this issue Dec 11, 2024 · 1 comment
Milestone

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Dec 11, 2024

Over time I've come to hate the name. It sounds like it's the path to the src/ folder, but it's actually the path to the enclosing module base folder

Something like basePath or millBasePath would be clearer and less confusing

@lihaoyi lihaoyi added this to the 0.13.0 milestone Dec 11, 2024
@lefou
Copy link
Member

lefou commented Dec 11, 2024

Maybe modulePath?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants