Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up RunScript helpers and Evaluator code #4094

Open
lihaoyi opened this issue Dec 9, 2024 · 1 comment
Open

Clean up RunScript helpers and Evaluator code #4094

lihaoyi opened this issue Dec 9, 2024 · 1 comment
Milestone

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Dec 9, 2024

Not sure exactly how, but they definitely feel a bit out of place, as a bunch of static helpers wrapping Evaluator

Noticed when working on #4091

Would need to be done in 0.13.0 when we can break bincompat

@lihaoyi lihaoyi added this to the 0.13.0 milestone Dec 9, 2024
@lihaoyi lihaoyi changed the title Clean up RunScript helpers Clean up RunScript helpers and Evaluator code Dec 10, 2024
@lihaoyi
Copy link
Member Author

lihaoyi commented Dec 16, 2024

#4144 helps a bit, but more to be done. In particular we can get rid of the Terminal.Task case class and branches since outside of test suites nobody should be running anonymous tasks directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant